Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SVG icons #2208

Merged
merged 1 commit into from Oct 9, 2017
Merged

Add SVG icons #2208

merged 1 commit into from Oct 9, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 3, 2017 •
edited

@spadgett spadgett mentioned this pull request Oct 3, 2017
Merged
@spadgett spadgett force-pushed the logos branch 5 times, most recently from a28e0c1 to ae870ad Compare October 4, 2017 12:21
@spadgett
Copy link
Member Author

spadgett commented Oct 4, 2017

Icons for subcategories:

openshift web console 2017-10-04 09-43-19

@sspeiche
Copy link

sspeiche commented Oct 4, 2017

Ooohhhh purdy

@spadgett spadgett mentioned this pull request Oct 5, 2017
Merged
@spadgett
Copy link
Member Author

spadgett commented Oct 5, 2017

@jeff-phillips-18 PTAL

@benjaminapetersen
Copy link
Contributor

[test] since Jenkins file changed

@benjaminapetersen
Copy link
Contributor

dist on this one, not tests

@spadgett
Copy link
Member Author

spadgett commented Oct 5, 2017

dist on this one, not tests

Yeah, needs a common and catalog release before I can add dist

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 6, 2017
@spadgett
Add SVG icons
ad0d847 
Use color SVG icons when available for recognized icon classes,
including those from openshift-logos.
@openshift-bot
Copy link

Evaluated for origin web console test up to ad0d847

@spadgett
Copy link
Member Author

spadgett commented Oct 9, 2017

[merge]

@spadgett spadgett changed the title [WIP] Add SVG icons Add SVG icons Oct 9, 2017
@openshift-bot
Copy link

Evaluated for origin web console merge up to ad0d847

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2017 •
edited

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/326/) (Base Commit: eb33544) (PR Branch Commit: ad0d847)

@openshift-bot
Copy link

Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/312/) (Base Commit: eb33544) (PR Branch Commit: ad0d847)

@openshift-bot openshift-bot merged commit 2ef8242 into openshift:master Oct 9, 2017
@spadgett spadgett deleted the logos branch October 9, 2017 16:37
@rhamilto rhamilto mentioned this pull request Nov 1, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Nov 1, 2017
@openshift-merge-robot
Merge pull request #2432 from rhamilto/catalog-icon-fix
dfd3293 
Automatic merge from submit-queue.

Fix bug where custom img icons don't appear in catalog cards

Introduced with #2208

![screen shot 2017-11-01 at 4 49 26 pm](https://user-images.githubusercontent.com/895728/32297259-fe6cad74-bf24-11e7-9e96-e157228b4798.PNG)
@spadgett spadgett mentioned this pull request Feb 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@spadgett @sspeiche @benjaminapetersen @openshift-bot @jeff-phillips-18 @dtaylor113 @openshift-ci-robot