Include details from failed DataService.list #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The promise returned from DataService.list did not include the HTTP status code and other information. Return the same object and properties as `$http`.
openshift-ci-robot
added
the
size/M
jeff-phillips-18
approved these changes
Oct 24, 2017
dtaylor113
approved these changes
Oct 24, 2017
jwforres
approved these changes
Oct 24, 2017
openshift-merge-robot
added a commit
to openshift/origin-web-console
that referenced
this pull request
Oct 24, 2017
Automatic merge from submit-queue. Use correct HTTP status from failed DataService.list Bumps origin-web-common to 0.0.69 Requires openshift/origin-web-common#236 Fixes #2354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promise returned from DataService.list did not include the HTTP
status code and other information. Return the same object and properties
as $http and other DataService deferreds.