Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct HTTP status from failed DataService.list #2360

Merged
merged 1 commit into from Oct 24, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 23, 2017

Bumps origin-web-common to 0.0.69

Requires openshift/origin-web-common#236
Fixes #2354

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2017
@spadgett spadgett changed the title Use correct HTTP status from failed DataService.list [WIP] Use correct HTTP status from failed DataService.list Oct 23, 2017
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2017
@jwforres
Copy link
Member

so all the list error handlers were broken?

are there list calls in catalog that we would need to fix?

@spadgett
Copy link
Member Author

so all the list error handlers were broken?

Yeah :/

are there list calls in catalog that we would need to fix?

I swept all 3 repos looking at list calls. The ones in the catalog repo weren't doing anything with the failure args (catalog service)

@jwforres
Copy link
Member

lgtm, just needs the common update it depends on

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2017
@spadgett
Copy link
Member Author

Updated with dist

@jwforres The logos changes in the dist are because we cut a logos release and we were using a ^ in bower.json. @rhamilto is removing the ^ in #2367

@spadgett spadgett changed the title [WIP] Use correct HTTP status from failed DataService.list Use correct HTTP status from failed DataService.list Oct 24, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2017
Bumps origin-web-common to 0.0.69
@spadgett
Copy link
Member Author

Rebased

@jwforres another look?

@jwforres
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 8ba070b into openshift:master Oct 24, 2017
@spadgett spadgett deleted the list-status branch October 24, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants