Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See whether "No <whatever> to show" messages look better outside of the tables #109

Closed
benjaminapetersen opened this issue Jun 24, 2016 · 2 comments
Closed

See whether "No <whatever> to show" messages look better outside of the tables #109

benjaminapetersen opened this issue Jun 24, 2016 · 2 comments
Assignees
@benjaminapetersen
Labels
area/styles priority/P3

Comments

@benjaminapetersen
Copy link
Contributor

Original issue openshift/origin#5412

Per @spadgett comment, there is an empty state for tables in patternfly:
https://www.patternfly.org/patterns/table-view/
@benjaminapetersen
Copy link
Contributor Author

@MDeMariaRH take a look at this one.

@spadgett spadgett mentioned this issue Jun 24, 2016
Closed
@benjaminapetersen benjaminapetersen mentioned this issue Jul 6, 2016
Closed
@benjaminapetersen
Copy link
Contributor Author

@MarkDeMaria this was one originally in the other bug list but might be quick.

@MarkDeMaria MarkDeMaria mentioned this issue Aug 29, 2016
Closed
@rhamilto rhamilto mentioned this issue Oct 12, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 17, 2017
@openshift-merge-robot
Merge pull request #2259 from rhamilto/issue-109
075822b 
Automatic merge from submit-queue.

Replacing empty tables with empty state message

Fixes #109
Replaces #497

HACK DAY!

Before:
![127 0 0 1-8443-console-project-my-project-dc-browse-deployments](https://user-images.githubusercontent.com/895728/31518381-10aab73c-af6d-11e7-81e0-a650c802b9d7.png)
![127 0 0 1-8443-console-project-my-project-dc-browse-deployments 1](https://user-images.githubusercontent.com/895728/31518396-19db6d7e-af6d-11e7-8c53-949714425d25.png)

After:
![localhost-9000-dev-console-project-my-project-empty-quota](https://user-images.githubusercontent.com/895728/31667665-20f0674a-b31e-11e7-8e83-8b0a047220ba.png)
![localhost-9000-dev-console-project-my-project-delete-browse-config-maps-labelfilter 7b 22matchexpressions 22- 5b 7b 22key 22- 22foo 22 22operator 22- 22exists 22 22values 22- 5b 5d 7d 5d 7d](https://user-images.githubusercontent.com/895728/31666705-2eb4f31c-b31b-11e7-98fe-96d86d643a2a.png)
f0x11 added a commit to f0x11/origin-web-console that referenced this issue Jan 31, 2018
@f0x11
Merge pull request openshift#109 from f0x11/poc
467a4a9 
Fix bug ORS-110.
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 13, 2018
@rhamilto
Replacing empty tables with empty state message
73f8ae3 
Fixes openshift#109
Replaces openshift#497

HACK DAY!
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 13, 2018
@rhamilto
Replacing empty tables with empty state message
13ff190 
Fixes openshift#109
Replaces openshift#497

HACK DAY!
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@rhamilto @f0x11
Replacing empty tables with empty state message
fcf1912 
Fixes openshift#109
Replaces openshift#497

HACK DAY!
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@rhamilto @f0x11
Replacing empty tables with empty state message
a8e0cf5 
Fixes openshift#109
Replaces openshift#497

HACK DAY!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminapetersen benjaminapetersen

Labels
area/styles priority/P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjaminapetersen @spadgett