Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See whether "No <whatever> to show" messages look better outside of the tables #5412

Closed
jwforres opened this issue Oct 27, 2015 · 5 comments
Closed

Comments

@jwforres
Copy link
Member

Today we show the tables with a message in them. See whether it would look better to hide the table completely when there are none. Should check what the patternfly recommendation is for this.

@spadgett
Copy link
Member

spadgett commented Jan 4, 2016

Patternfly empty state for tables is on this page:

https://www.patternfly.org/patterns/table-view/

@benjaminapetersen
Copy link
Contributor

@MDeMariaRH this is a good one to hit. I'll create a new issue in origin-web-console & reference this.

@spadgett
Copy link
Member

We should look at using the empty state styles we use elsewhere for this. One example:

https://github.com/openshift/origin-web-console/blob/a08db604494995962b9cc717c2d2d0703c43b865/app/views/browse/build-config.html#L78-L95

@spadgett
Copy link
Member

See also https://www.patternfly.org/pattern-library/communication/empty-state/#_

(Although the styles we use predate the pattern, so they might be slightly different.)

@spadgett
Copy link
Member

Closing in favor of openshift/origin-web-console#109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants