Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic table at mobile wastes vertical space showing the arrows #1232

Closed
jwforres opened this issue Feb 9, 2017 · 4 comments
Closed

Traffic table at mobile wastes vertical space showing the arrows #1232

jwforres opened this issue Feb 9, 2017 · 4 comments

Comments

@jwforres
Copy link
Member

jwforres commented Feb 9, 2017

The Service page's Traffic table is wasting a lot of vertical space at mobile showing the TD's with the arrows in them.

  1. Do we still need the arrows at mobile?
  2. If we do could we do something like move the arrow up to the left of the content in the previous TD so we dont waste whole rows on it

traffic-table-mobile

@jwforres
Copy link
Member Author

jwforres commented Feb 9, 2017

@ncameronbritt @spadgett

@rhamilto
Copy link
Member

rhamilto commented Apr 19, 2017

Maybe arrows overlaying the border between cells?

3fc2a5ba-eecb-11e6-999e-9bcad03e5928

I think I like the arrows offset a bit:

3fc2a5ba-eecb-11e6-999e-9bcad03e5928-2

@ncameronbritt
Copy link

To me, having the arrows at all seems a little strange since what I'm looking at appears to be a table (or definition list).

If it's important to understand those connections, could the labels for those three lines be in a row with the values underneath, reducing three lines to two?

@beanh66
Copy link
Member

beanh66 commented Jul 21, 2017

Agreed, using the arrows vertically seems strange. I'd say drop the arrows for mobile if possible, and if we think they can't go then try the suggestion from @ncameronbritt with still horizontal arrows but stacking the label over the value.

@rhamilto rhamilto assigned rhamilto and unassigned jwforres Oct 17, 2017
openshift-merge-robot added a commit that referenced this issue Oct 17, 2017
Automatic merge from submit-queue.

Hiding td[role=presentation] at mobile to fix traffic table bug

Fixes #1232 

![screen shot 2017-10-17 at 2 30 38 pm](https://user-images.githubusercontent.com/895728/31683187-480ea82e-b34a-11e7-997b-effbbfd51f07.PNG)
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants