You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The resume rollouts action on the overview and browse pages doesn't disappear on click until after we get a watch update saying that spec.paused is set to false. This means the link appears to do nothing if the websocket update doesn't happen immediately.
@smarterclayton Resume rollouts is working for me in current master for both deployments and deployment configs, so I suspect it is in fact slow watches.
The text was updated successfully, but these errors were encountered:
From what I gather here, we can trigger an alert to close immediately by returning true from the underlying callback function:
// scripts/directives/alerts.js$scope.onClick=function(alert,link){if(_.isFunction(link.onClick)){// If onClick() returns true, also hide the alert.varclose=link.onClick();// <-- we could update this to support a promise...if(close){alert.hidden=true;}}};
So we would have to consider how to update this:
// services/resourceAlerts.js// inside getPausedDeploymentAlerts()
onClick: function(){// we could return the promise, but if our problem is that we need the user to // see something immediately this probably won't be a good solution...DeploymentsService.setPaused(deployment,false,{namespace: deployment.metadata.namespace}).then(_.noop,function(e){/* stuff */});// or do we just return `true` to let the UI update, // but surface a new error/alert if things don't actually // resolve well?}
Since the error handler for DeploymentsService.setPaused will pop a new alert, I think we can return true from the function to dismiss the immediate modal.
The resume rollouts action on the overview and browse pages doesn't disappear on click until after we get a watch update saying that
spec.paused
is set to false. This means the link appears to do nothing if the websocket update doesn't happen immediately.@smarterclayton Resume rollouts is working for me in current master for both deployments and deployment configs, so I suspect it is in fact slow watches.
The text was updated successfully, but these errors were encountered: