Fix problem where UI appears unresponsive while waiting for websocket update #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also have the issue on the deployment config and deployment pages |
spadgett
requested changes
Sep 28, 2017
benjaminapetersen
force-pushed
the
bpeterse/issue/1875-resume-rollouts-stalled-ui
branch
from
2a81b7f
to
2623975
Compare
|
Looking at these. |
benjaminapetersen
force-pushed
the
bpeterse/issue/1875-resume-rollouts-stalled-ui
branch
from
2623975
to
620ab1e
Compare
|
Updated. <alerts
ng-if="deployment.spec.paused && !updatingPausedState"
alerts="pausedAlert"></alerts> |
|
This can go today as well, if we can wake up the merge queue... |
spadgett
approved these changes
Oct 3, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 620ab1e |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/322/) (Base Commit: ec0a953) (PR Branch Commit: 620ab1e) |
benjaminapetersen
deleted the
bpeterse/issue/1875-resume-rollouts-stalled-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1875
@spadgett
(aside, i think the dist having something to the effect of
return !0forreturn trueis kinda funny... optimize out those 2 characters 😄 )