Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left nav in mini-mode is missing alt text for icons #2294

Closed
jwforres opened this issue Oct 17, 2017 · 1 comment
Closed

Left nav in mini-mode is missing alt text for icons #2294

jwforres opened this issue Oct 17, 2017 · 1 comment
Assignees
@sg00dwin
Labels
area/accessibility kind/bug Categorizes issue or PR as related to a bug. priority/P2
Milestone
3.7.0

Comments

@jwforres
Copy link
Member

When you click the hamburger to collapse the left nav, the text is set to display:none which makes it invisible to a screen reader. There is no alternative text for the icons in this case.
@jwforres jwforres added area/accessibility kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Oct 17, 2017
sg00dwin added a commit to sg00dwin/origin-web-console that referenced this issue Oct 19, 2017
@sg00dwin
Update vertical nav items adding title attribute and aria-hidden true.
4c56c79 
Fixes openshift#2294
@sg00dwin sg00dwin mentioned this issue Oct 19, 2017
Closed
@rhamilto rhamilto assigned sg00dwin and unassigned spadgett Oct 19, 2017
@spadgett
Copy link
Member

This should probably be addressed in patternfly. They make .list-group-item-value hidden, but maybe it should be .sr-only() instead.

@jwforres jwforres added this to the 3.7.0 milestone Oct 23, 2017
@rhamilto rhamilto mentioned this issue Oct 23, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 23, 2017
@openshift-merge-robot
Merge pull request #2359 from rhamilto/sg00dwin-vert-nav-collapsed-ic…
0f2d9ba 
…on-title

Automatic merge from submit-queue.

Add alt text for left nav in mini-mode

Fixes #2294
Replaces #2309

fyi @sg00dwin
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@sg00dwin @f0x11
Add alt text for left nav in mini-mode
d340169 
Fixes openshift#2294
Replaces openshift#2309
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@sg00dwin @f0x11
Add alt text for left nav in mini-mode
2bec7bc 
Fixes openshift#2294
Replaces openshift#2309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sg00dwin sg00dwin

Labels
area/accessibility kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
3 participants
@spadgett @jwforres @sg00dwin