Update vertical nav items adding title attribute and aria-hidden true. #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
spadgett
reviewed
Oct 19, 2017
| @@ -24,13 +24,13 @@ | |||
| ng-mouseleave="onMouseLeave(primaryItem)" | |||
| class="list-group-item"> | |||
| <a ng-if="primaryItem.href" ng-href="{{navURL(primaryItem.href)}}" ng-click="itemClicked(primaryItem)"> | |||
| <span class="{{primaryItem.iconClass}}"></span> <span class="list-group-item-value">{{primaryItem.label}}</span> | |||
| <span alt="{{primaryItem.label}}" aria-hidden="true" class="{{primaryItem.iconClass}}"></span> <span class="list-group-item-value">{{primaryItem.label}}</span> | |||
There was a problem hiding this comment.
Maybe (untested)
<span title="{{primaryItem.label}}" class="{{primaryItem.iconClass}}" aria-hidden="true"></span>
<span class="list-group-item-value">{{primaryItem.label}}</span>
<span ng-if="nav.collapsed && !isMobile" class="sr-only">{{primaryItem.label}}</span>But I think it should be fixed in Patternfly.
|
@sg00dwin PR needs rebase |
openshift-merge-robot
added
the
needs-rebase
|
Replaced by #2359 |
f0x11
pushed a commit
to f0x11/origin-web-console
that referenced
this pull request
Mar 26, 2018
f0x11
pushed a commit
to f0x11/origin-web-console
that referenced
this pull request
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2294