Show help about compute units #1027
Conversation
spadgett
force-pushed
the
units-help
branch
2 times, most recently
from
8c27db8
to
35044a2
Compare
|
|
| @@ -365,6 +365,9 @@ | |||
| expand="true" | |||
| can-toggle="false" | |||
| > | |||
| <div class="learn-more-block"> | |||
| <a href="" ng-click="showComputeUnitsHelp()">What are millicores and MiB?</a> | |||
| </div> | |||
There was a problem hiding this comment.
@jwforres Different text here because there is already an "About Resource Limits" link for the form section. Let me know if you have a better idea for where to put it.
|
@spadgett in your first screenshot, what if "CPU and memory" was a link instead? or maybe the order of the two links just needs to be reversed, i think it would make more sense to have the simple About Compute Resources and then the Learn More -> |
|
@jwforres I think I like changing the order. Or I could even remove the learn more link since it's in the dialog. |
|
Pushed a change to switch the order for now |
|
for the resource limits editor, I think I would rather have a ? link next to the units dropdown than have the full "What are millicores and MiB?" Its tough since ? is usually reserved for the popups... |
|
Maybe in the help text? The minimum amount of CPU the container is guaranteed. Can be specified in
<a href="">millicores or cores</a>. |
|
@spadgett yep i like that idea |
|
@jwforres Not sure about it now that I've tried it. It's odd since it's repeated twice for CPU and twice for memory, and they all bring up the same dialog.
|
openshift-bot
added
the
needs-rebase
|
What if you took off the sentence you added and instead made "CPU" the link, i think that still works with the content of the dialog. |
|
|
|
Yeah i'm fine with this, how do you feel about it?
…On Tue, Dec 13, 2016 at 3:59 PM, Sam Padgett ***@***.***> wrote:
[image: screen shot 2016-12-13 at 3 58 24 pm]
<https://cloud.githubusercontent.com/assets/1167259/21158895/0f8ef2dc-c14d-11e6-8677-449562dc7dc5.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1027 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7dP-iJE5PenCRwXUxWafJj66WdGxks5rHwcfgaJpZM4LLB4j>
.
|
openshift-bot
removed
the
needs-rebase
|
With input from @rhamilto 👍
|
|
screenshot LGTM, let me know when the changes are pushed |
|
@jwforres changes pushed |
|
[merge] |
Add a link to resource limit forms and metrics pages that explain compute units like millicores and MiB. The link opens a dialog with a brief description of compute resources and tables for binary and decimal units.
|
Resolved dist conflict [merge] |
|
Evaluated for origin web console merge up to b16b2bd |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/854/) (Base Commit: 076ed5a) |
Add a link to resource limit forms and metrics pages that explain compute units like millicores and MiB. The link opens this dialog:
cc @derekwaynecarr
Fixes openshift/origin#7768