Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other resources list update #1572

Merged
merged 1 commit into from
May 24, 2017
Merged

Other resources list update #1572

merged 1 commit into from
May 24, 2017

Conversation

benjaminapetersen
Copy link
Contributor

Depends on web-common PR 77

These resources pass the 'list' verb test:

[
  "Endpoints",
  "PodTemplate",
  "ServiceAccount",
  "HorizontalPodAutoscaler",
  "DaemonSet",
  "Ingress",
  "NetworkPolicy",
  "ReplicationControllerDummy",
  "PodDisruptionBudget",
  "RoleBinding",
  "Role",
  "PodPreset",
  "Policy",
  "PolicyBinding",
  "RoleBindingRestriction",
  "RoleBinding",
  "Role",
  "Template",
  "EgressNetworkPolicy"
]

these resources do not:

[
  "LocalSubjectAccessReview",
  "LocalResourceAccessReview",
  "LocalSubjectAccessReview",
  "ResourceAccessReview",
  "SelfSubjectRulesReview",
  "SubjectAccessReview",
  "SubjectRulesReview",
  "PodSecurityPolicyReview",
  "PodSecurityPolicySelfSubjectReview",
  "PodSecurityPolicySubjectReview"
]

Moving the apiService updates to web-common to PR first, then will update & remove the [WIP]

@benjaminapetersen
Copy link
Contributor Author

Current master lists these:

master:
other_resource_master

this branch:
is_listable_branch

and this branch, if i clear the AVAILABLE_KINDS_BLACKLIST:
clear_blacklist

@benjaminapetersen benjaminapetersen force-pushed the trello-EjGHumwk-other-resources-list-update branch from 4e13460 to 12bfb4c Compare May 24, 2017 19:15
@benjaminapetersen
Copy link
Contributor Author

rebased & squashed

@benjaminapetersen benjaminapetersen force-pushed the trello-EjGHumwk-other-resources-list-update branch 2 times, most recently from 4a5a355 to 57a7244 Compare May 24, 2017 19:54
@benjaminapetersen
Update the Other Resources Page to only show resources supporting the…
3ca14c4 
… 'List' verb

- also empty out AVAILABLE_KINDS_BLACKLIST
@benjaminapetersen benjaminapetersen force-pushed the trello-EjGHumwk-other-resources-list-update branch from 57a7244 to 3ca14c4 Compare May 24, 2017 20:11
@benjaminapetersen benjaminapetersen changed the title [WIP] Other resources list update Other resources list update May 24, 2017
@jwforres
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 3ca14c4

@openshift-bot
Copy link

openshift-bot commented May 24, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1407/) (Base Commit: da9b22a)

@openshift-bot openshift-bot merged commit 5755f73 into openshift:master May 24, 2017
@benjaminapetersen benjaminapetersen deleted the trello-EjGHumwk-other-resources-list-update branch May 25, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwforres jwforres jwforres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaminapetersen @jwforres @openshift-bot