Bug 1476157 - Fix minification problems due to dependency injection #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our version of ngAnnotate does not handle components, which causes runtime errors in the built binary due to a recent component. Switch the component to use the array notation for dependency injection and put it in its own file.
|
[merge][severity: blocker] |
|
Evaluated for origin web console merge up to 3c8659c |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/59/) (Base Commit: f62c98f) (PR Branch Commit: 3c8659c) (Extended Tests: blocker) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our version of ngAnnotate does not handle components, which causes
runtime errors in the built binary due to a recent component. Switch the
component to use the array notation for dependency injection and put it
in its own file.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476157
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1476216
Opened tech debt issue #1889 for upgrading grunt-ng-annotate.