[3.6] Fix Bug 1543435 - A-MQ Components not visible in Java Console when using IE11 browser #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
|
@akieling Unfortunately, you might need to use an older version of node in our older release branches. We had an issue where you would generate different dist depending on the version you used. Verifying that checked in built files under dist match the source...
diff --git a/dist/scripts/vendor.js b/dist/scripts/vendor.js
index 1057b572..d27002ff 100644
--- a/dist/scripts/vendor.js
+++ b/dist/scripts/vendor.js
@@ -8062,7 +8062,7 @@ delete c[b.id], delete d[a];
http:80,
https:443,
ftp:21
-}, sf = b("$location"), tf = /^\s*[\\\/]{2,}/, uf = {
+}, sf = b("$location"), tf = /^\s*[\\/]{2,}/, uf = {
$$absUrl:"",
$$html5:!1,
$$replace:!1, |
|
Related issue for the dist problem: #1667 This is fixed in master, but not for older branches. You can either install a node version older than v4 or manually undo this change in vendor.js |
|
@spadgett I've rebuilt the project using npm 3.10.10 and it seems to have fixed the issue with vendor.js. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
abkieling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following bug on OpenShift Enterprise 3.6:
https://bugzilla.redhat.com/show_bug.cgi?id=1543435