Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime error in service group watch when service undefined #70

Merged
merged 1 commit into from Jun 17, 2016

Conversation

spadgett
Copy link
Member

@jwforres PTAL

@spadgett
Copy link
Member Author

Fixes:

angular.js:11706 TypeError: Cannot read property 'metadata' of undefined
    at serviceGroup.js:68
    at watchGroupAction (angular.js:14105)
    at Scope.$eval (angular.js:14570)
    at Scope.$digest (angular.js:14386)
    at Scope.$apply (angular.js:14675)
    at done (angular.js:9725)
    at completeRequest (angular.js:9915)
    at XMLHttpRequest.requestLoaded (angular.js:9856)

@spadgett
Copy link
Member Author

@jwforres hold, unserviced RCs are not showing up :(

@spadgett
Copy link
Member Author

[merge]

@openshift-bot
Copy link

openshift-bot commented Jun 17, 2016

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/46/)

@openshift-bot
Copy link

Evaluated for origin web console merge up to d904e41

@openshift-bot openshift-bot merged commit d97c6c1 into openshift:master Jun 17, 2016
@spadgett spadgett deleted the service-null-check branch June 17, 2016 16:27
f0x11 added a commit to f0x11/origin-web-console that referenced this pull request Jan 10, 2018
@yhchen modify hawk-console.yaml quota of memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants