Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse help templating from upstream #10957

Closed
fabianofranz opened this issue Sep 16, 2016 · 0 comments
Closed

Reuse help templating from upstream #10957

fabianofranz opened this issue Sep 16, 2016 · 0 comments
Assignees
@fabianofranz
Labels
area/techdebt component/cli kind/post-rebase priority/P2

Comments

@fabianofranz
Copy link
Member

We recently upstreamed our help templating system, with additional improvements like automatically correcting help examples tabs. We need to get rid of our own and reuse the one from upstream which landed in the rebase. Caveat: usage at the bottom.
@fabianofranz fabianofranz self-assigned this Sep 16, 2016
@fabianofranz fabianofranz mentioned this issue Sep 19, 2016
Merged
@fabianofranz fabianofranz mentioned this issue Jul 27, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Aug 2, 2017
@openshift-merge-robot
Merge pull request #15512 from fabianofranz/reuse_templating_from_ups…
1b5a96a 
…tream

Automatic merge from submit-queue (batch tested with PRs 15512, 15582, 15125, 15590, 15593)

Remove duplicate code and reuse templating from upstream

Fixes #10957
Fixes #11035

We upstreamed CLI templating, so this removes the code we had in Origin and reuse it from upstream. What's left is required to allow the different positioning of "Usage" in our help.

PTAL @smarterclayton @juanvallejo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabianofranz fabianofranz

Labels
area/techdebt component/cli kind/post-rebase priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabianofranz