-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oc cluster up fails with leading 0 in docker version #13219
Comments
i think there's a fix underway for this, @csrwng can point to it. |
additional info
|
This goes too for stable version in macOS: Server https://192.168.99.100:8443 $ oc cluster up |
I can also confirm this:
|
The fix has already merged in origin master. If you build an oc client from master, things should work. |
Thanks @csrwng, confirmed. What's the release schedule like for each pre-release? |
While this fixes the docker version parsing in cluster up, doesn't a proper fix that includes being able to actually run pods rely on a fix for kubernetes/kubernetes#42492 ? A simple fix for both of these would be to remove leading zeroes in version components before parsing as semver - according to docker's new versioning scheme this would end up being semver compatible and be backwards compatible too. |
@jimmidyson I don't believe the error stops you from running pods. Until now I've had no problems running pods on origin v1.5.0-alpha.3 with the latest docker. |
@MichaelMarkieta the fix will go in the final v1.5 release. I'm less sure about the the schedule for it. |
@csrwng When you say latest Docker do you mean 17.03-ce? |
Yes |
@csrwng Hmm yeah works for me too - interesting. Sure this didn't work before... thanks though! |
I can't run pods when using
|
oc cluster up works fine btw from master - but the kubelet probably needs an update? |
@Kargakis which version of the kubelet are you running? |
@csrwng the one that runs inside openshift/origin:v1.5.0-alpha.3 Interestingly, running from Kube HEAD, it works fine... |
Using hack/local-up-cluster |
@Kargakis I hit that same issue, hence my comment before, but it seems to be inconsistent as it's working for me now with same 1.5.0-alpha.3 image... Very odd. |
Node status from Kube cluster
:) |
I am running on Fedora 25 btw, this thread seems to be about Mac so ignore me. |
I'm on Fedora 25 too... please don't ignore us ;) |
Is there any chance that this get backported to the previous releases, since this breaks all the previous |
/cc @smarterclayton |
I'm ok with backport |
also fix |
Docker does not use semantic versioning, so a test for the leading zero is pointless. Use an enum. |
oc cluster up fails with latest docker for mac Version 17.03.0-ce-mac1 (15587)
Version
oc v1.5.0-alpha.3+cf7e336
kubernetes v1.5.2+43a9be4
features: Basic-Auth
Unable to connect to the server: EOF
Steps To Reproduce
Current Result
$ oc cluster up -- Checking OpenShift client ... OK -- Checking Docker client ... OK -- Checking Docker version ... FAIL Error: Minor number must not contain leading zeroes "03"
Expected Result
a local openshift cluster needs to be setup
The text was updated successfully, but these errors were encountered: