Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions in Swagger API "x-kubernetes-group-version-kind" all reporting as "latest" #15666

Closed
jim-minter opened this issue Aug 7, 2017 · 3 comments · Fixed by #15786
Closed

Versions in Swagger API "x-kubernetes-group-version-kind" all reporting as "latest" #15666

jim-minter opened this issue Aug 7, 2017 · 3 comments · Fixed by #15786
Assignees
@deads2k
Labels
component/restapi kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@jim-minter
Copy link
Contributor

Since the 1.7 rebase, the version information is missing under "x-kubernetes-group-version-kind" under api/swagger-spec/openshift-openapi-spec.json - instead of reporting things like "version": "v1" (or whatever), everything is coming through as "version": "latest"
@jim-minter
Copy link
Contributor Author

@deads2k or @sttts would you be able to take a look at this?

@deads2k
Copy link
Contributor

deads2k commented Aug 7, 2017

@deads2k or @sttts would you be able to take a look at this?

Is it blocking something? I took a guess at a p2 assuming that its not.

@jim-minter
Copy link
Contributor Author

It'd be handy if it were fixed as it causes the api documentation autogeneration that I'm working on to come out wrong.

@pweil- pweil- added component/restapi kind/bug Categorizes issue or PR as related to a bug. labels Aug 9, 2017
@jim-minter jim-minter mentioned this issue Aug 15, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Aug 16, 2017
@openshift-merge-robot
Merge pull request #15786 from jim-minter/issue15666
f133fbf 
Automatic merge from submit-queue

fix swagger version reporting

fixes #15666 

It was the change in serialisation of "Version" to "version" under "x-kubernetes-group-version-kind" that made us hit the rogue sed command.

@deads2k fyi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deads2k deads2k

Labels
component/restapi kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix swagger version reporting jim-minter/origin
3 participants
@jim-minter @pweil- @deads2k