fix swagger version reporting #15786
Conversation
openshift-merge-robot
added
the
size/XXL
| @@ -49,7 +49,7 @@ generated_file="${SWAGGER_SPEC_OUT_DIR}/openshift-openapi-spec.json" | |||
| oc get --raw "/swagger.json" --config="${MASTER_CONFIG_DIR}/admin.kubeconfig" > "${generated_file}" | |||
|
|
|||
| os::util::sed 's|https://127.0.0.1:38443|https://127.0.0.1:8443|g' "${generated_file}" | |||
| os::util::sed -E 's|"version": "[^\"]+"|"version": "latest"|g' "${generated_file}" | |||
| os::util::sed -E '0,/"version":/ s|"version": "[^\"]+"|"version": "latest"|g' "${generated_file}" | |||
There was a problem hiding this comment.
sorry my sed-fu is not that great, this new prefix does what exactly?
There was a problem hiding this comment.
Does the first replace in the file then leaves the rest of the instances alone. "Between lines 0 and the line containing the first match, do the following replace". jq would be better here, but...
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jim-minter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
fixes #15666
It was the change in serialisation of "Version" to "version" under "x-kubernetes-group-version-kind" that made us hit the rogue sed command.
@deads2k fyi