Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Warn on resources out of proportion for simple builds #23423

Closed
mcandre opened this issue Jul 18, 2019 · 4 comments
Closed

Enhancement: Warn on resources out of proportion for simple builds #23423

mcandre opened this issue Jul 18, 2019 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mcandre
Copy link

mcandre commented Jul 18, 2019

Really simple builds, such as yum/apt/apk, wget/curl, tar/gunzip; or ADD/COPY of a static artifact, do not require much in the way of resources to quickly and successfully complete a build. I wonder if OpenShift could detect these opportunities for driving down cost, by reminding the user to set more appropriate resource constraints.

Even with the implicit git clone that often runs as part of the build process, 100m cpu request, 100Mi memory request, with 1 cpu and 1Gi memory limits, is more than sufficient for OpenShift to gallop through these basic builds. More intensive builds involving compilation or database daemons often don't need more than 1 cpu, 1Gi memory (C, C++, Go); or 1 cpu, 4Gi (Haskell, PostgreSQL) to work well.

And so financiers would appreciate if OpenShift could detect such simple builds, such as by checking Dockerfiles for more complicated build commands, and recommending to administrators that resources be lowered. I think this is technically possible. Do you think this would this deliver a lot of value to customers with a reasonably maintainable whitelist of lean Dockerfile build commands?

Where requests are far above these values (or worse, match the limits), then OpenShift could assist users in keeping costs down by recommending that resources be lowered.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2019
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2019
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants