Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router and Registry should have readiness checks and health checks #5900

Closed
smarterclayton opened this issue Nov 13, 2015 · 5 comments
Closed

Comments

@smarterclayton
Copy link
Contributor

Both should have those set up by default.

@ramr @pweil- @miminar

If we have them, then we should be using them in the registry / router generators. Both should not return true until the members are ready to be in rotation.

@miminar
Copy link

miminar commented Nov 16, 2015

#5892 partially addresses this by adding liveness probe to docker-registry. I'll build on top of it to add readiness checks to both registry and route pods.

@miminar
Copy link

miminar commented Nov 16, 2015

Blocked by #4339. No longer blocked. #5404 re-enabled liveness probe for the registry.

@ramr
Copy link
Contributor

ramr commented Nov 19, 2015

@smarterclayton we can do it by checking the router itself - aka check port 80/443. Currently, we have a liveness probe for haproxy and can add a readiness one which is same/similar.

However, the waiting for members to be ready in rotation will probably not work for the router case ... won't be correct to wait for multiple routes + multiple backends to all be available as some routes might be slow getting available aka the drools case and shouldn't affect the availability of other routes.
Note to self: need to check if there's something we can use for readiness/liveness checks for F5.

@ramr
Copy link
Contributor

ramr commented Nov 19, 2015

Ignore previous comment, didn't realize @miminar already had a PR for this - thanks @miminar

@miminar
Copy link

miminar commented Dec 21, 2015

#6439 is a last piece providing readiness probe for registry.

@liggitt liggitt modified the milestones: 1.1.1, 1.1.x Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants