Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The deploymentConfig describer isn't aware of From field of image change triggers #874

Closed
ironcladlou opened this issue Feb 4, 2015 · 0 comments
Closed

The deploymentConfig describer isn't aware of From field of image change triggers #874

ironcladlou opened this issue Feb 4, 2015 · 0 comments

Comments

@ironcladlou
Copy link
Contributor

The CLI describer for deployment configs needs to be made aware of the new From field of image change triggers. It currently won't render the trigger details correctly unless using the legacy RepositoryName field.
ironcladlou added a commit to ironcladlou/origin that referenced this issue Feb 4, 2015
@ironcladlou
Render image trigger From field for deploy configs
e191f28 
Render deployment image trigger From field when present.

Closes openshift#874.
This was referenced Feb 4, 2015
Closed
Merged
jpeeler added a commit to jpeeler/origin that referenced this issue Jun 15, 2017
@jpeeler
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
1836b6f 
…service-catalog/' changes from c91fecb..1bfff53

1bfff53 instance never provisioned should just delete (openshift#891)
1ae26db Adding a fake broker server (openshift#928)
6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931)
8ac0775 Merge branch 'pr/927'
02af952 Merge branch 'pr/876'
2aa84f9 add Jenkins badge to README
0c08788 Brokers must have at least one service (openshift#930)
cbfa39b Add PodPreset support (openshift#917)
0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916)
066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877)
203af5c Add leader election namespace configuration (openshift#920)
5831502 Add example JSON schema to controller unit tests (openshift#918)
b78ab99 Fix usage of finalizers (openshift#894)
d3d29f0 Enable pprof in controller-manager (openshift#896)
f4233a0 Correct parameter schema support (openshift#912)
05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910)
97d278a Add support for OSB parameter schemas (openshift#822)
3e4120e Fix nil dereference panic on request timeout (openshift#906)
d8c7494 Add feature gate for audit options in helm chart (openshift#904)
89ce1cd Decompose controller unit tests (openshift#899)
a1e83b2 Add e2e for walkthrough (openshift#832)
4679685 Add support for audit log options (openshift#897)
262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853)
7295dad Validate that a ServiceClass must have at least one plan (openshift#879)
9db9fa4 Decompose controller.go (openshift#893)
c3ea9bd Nits in our types (openshift#854)
1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892)
5e6925d Clean up the OSB client (openshift#888)
fe6aee9 cleaning up logs and adding more log detail (openshift#874)
f41516f Detect if a TPR update represents a soft delete (openshift#836)
9ce99f3 Add functions on Makefile for build and tag
REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build
REVERT: 55ccf3d origin build: add _output to .gitignore
REVERT: 8352e14 origin build: make build-go and build-cross work
REVERT: d969641 origin build: modify hard coded path
REVERT: 30000cc origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 1bfff53
jpeeler added a commit to jpeeler/origin that referenced this issue Jun 15, 2017
@jpeeler
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
69f2840 
…service-catalog/' changes from c91fecb..568a7b9

568a7b9 origin build: add origin tooling
1bfff53 instance never provisioned should just delete (openshift#891)
1ae26db Adding a fake broker server (openshift#928)
6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931)
8ac0775 Merge branch 'pr/927'
02af952 Merge branch 'pr/876'
2aa84f9 add Jenkins badge to README
0c08788 Brokers must have at least one service (openshift#930)
cbfa39b Add PodPreset support (openshift#917)
0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916)
066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877)
203af5c Add leader election namespace configuration (openshift#920)
5831502 Add example JSON schema to controller unit tests (openshift#918)
b78ab99 Fix usage of finalizers (openshift#894)
d3d29f0 Enable pprof in controller-manager (openshift#896)
f4233a0 Correct parameter schema support (openshift#912)
05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910)
97d278a Add support for OSB parameter schemas (openshift#822)
3e4120e Fix nil dereference panic on request timeout (openshift#906)
d8c7494 Add feature gate for audit options in helm chart (openshift#904)
89ce1cd Decompose controller unit tests (openshift#899)
a1e83b2 Add e2e for walkthrough (openshift#832)
4679685 Add support for audit log options (openshift#897)
262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853)
7295dad Validate that a ServiceClass must have at least one plan (openshift#879)
9db9fa4 Decompose controller.go (openshift#893)
c3ea9bd Nits in our types (openshift#854)
1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892)
5e6925d Clean up the OSB client (openshift#888)
fe6aee9 cleaning up logs and adding more log detail (openshift#874)
f41516f Detect if a TPR update represents a soft delete (openshift#836)
9ce99f3 Add functions on Makefile for build and tag
REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build
REVERT: 55ccf3d origin build: add _output to .gitignore
REVERT: 8352e14 origin build: make build-go and build-cross work
REVERT: d969641 origin build: modify hard coded path
REVERT: 30000cc origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 568a7b9dbdc4fdd1fabffdd52af030ec73124b89
jpeeler pushed a commit to jpeeler/origin that referenced this issue Feb 1, 2018
@arschles
cleaning up logs and adding more log detail (openshift#874)
fe6aee9 
* cleaning up logs and adding more log detail

- Splitting up long log lines
- Logging the error code from failed calls to brokers on delete instance

* changing binding condition back to what was expected in unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Render image trigger From field for deploy configs ironcladlou/origin
1 participant
@ironcladlou