Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using github.com/openshift/imagebuilder #10216

Merged
merged 5 commits into from Aug 4, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2,386 changes: 1,261 additions & 1,125 deletions Godeps/Godeps.json

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions hack/copy-kube-artifacts.sh
Expand Up @@ -65,6 +65,7 @@ rsync -av \
--exclude='*' \
--prune-empty-dirs \
$KUBE_ROOT/vendor/ $GODEP_ROOT <<EOF
/github.com/onsi/ginkgo/ginkgo/**.go
/github.com/golang/mock/gomock/**.go
/github.com/google/cadvisor/info/v1/test/**.go
EOF
2 changes: 1 addition & 1 deletion pkg/bootstrap/docker/dockerhelper/helper.go
Expand Up @@ -17,8 +17,8 @@ import (
"github.com/golang/glog"
"golang.org/x/net/context"

"github.com/openshift/imagebuilder/imageprogress"
starterrors "github.com/openshift/origin/pkg/bootstrap/docker/errors"
"github.com/openshift/origin/pkg/util/docker/dockerfile/builder/imageprogress"
)

const openShiftInsecureCIDR = "172.30.0.0/16"
Expand Down
2 changes: 1 addition & 1 deletion pkg/build/builder/dockerutil.go
Expand Up @@ -15,7 +15,7 @@ import (
s2iapi "github.com/openshift/source-to-image/pkg/api"
"github.com/openshift/source-to-image/pkg/tar"

"github.com/openshift/origin/pkg/util/docker/dockerfile/builder/imageprogress"
"github.com/openshift/imagebuilder/imageprogress"
)

var (
Expand Down
23 changes: 17 additions & 6 deletions pkg/cmd/cli/cmd/dockerbuild/dockerbuild.go
Expand Up @@ -7,6 +7,7 @@ import (
"path/filepath"
"strings"

dockertypes "github.com/docker/engine-api/types"
docker "github.com/fsouza/go-dockerclient"
"github.com/golang/glog"
"github.com/spf13/cobra"
Expand All @@ -15,9 +16,9 @@ import (
kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
"k8s.io/kubernetes/pkg/util/interrupt"

dockerbuilder "github.com/openshift/imagebuilder/dockerclient"
cmdutil "github.com/openshift/origin/pkg/cmd/util"
"github.com/openshift/origin/pkg/cmd/util/clientcmd"
"github.com/openshift/origin/pkg/util/docker/dockerfile/builder"
)

const (
Expand Down Expand Up @@ -46,7 +47,7 @@ type DockerbuildOptions struct {

MountSpecs []string

Mounts []builder.Mount
Mounts []dockerbuilder.Mount
Directory string
Tag string
DockerfilePath string
Expand Down Expand Up @@ -101,13 +102,13 @@ func (o *DockerbuildOptions) Complete(f *clientcmd.Factory, cmd *cobra.Command,
o.DockerfilePath = filepath.Join(o.Directory, "Dockerfile")
}

var mounts []builder.Mount
var mounts []dockerbuilder.Mount
for _, s := range o.MountSpecs {
segments := strings.Split(s, ":")
if len(segments) != 2 {
return kcmdutil.UsageError(cmd, "--mount must be of the form SOURCE:DEST")
}
mounts = append(mounts, builder.Mount{SourcePath: segments[0], DestinationPath: segments[1]})
mounts = append(mounts, dockerbuilder.Mount{SourcePath: segments[0], DestinationPath: segments[1]})
}
o.Mounts = mounts

Expand All @@ -132,13 +133,23 @@ func (o *DockerbuildOptions) Run() error {
return err
}
defer f.Close()
e := builder.NewClientExecutor(o.Client)
e := dockerbuilder.NewClientExecutor(o.Client)
e.Out, e.ErrOut = o.Out, o.Err
e.AllowPull = o.AllowPull
e.Directory = o.Directory
e.TransientMounts = o.Mounts
e.Tag = o.Tag
e.AuthFn = o.Keyring.Lookup
e.AuthFn = func(image string) ([]dockertypes.AuthConfig, bool) {
auth, ok := o.Keyring.Lookup(image)
if !ok {
return nil, false
}
var engineAuth []dockertypes.AuthConfig
for _, c := range auth {
engineAuth = append(engineAuth, c.AuthConfig)
}
return engineAuth, true
}
e.LogFn = func(format string, args ...interface{}) {
if glog.V(2) {
glog.Infof("Builder: "+format, args...)
Expand Down