Switch to using github.com/openshift/imagebuilder #10216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] @liggitt please take a look at the bump changes. I've already pushed stable-20160804 (shame this isn't the year 3216) |
Upstream our commits, also clean up some files that were copied in, and cleanup the Godeps.json file
smarterclayton
force-pushed
the
upstream
branch
from
edd5aaf
to
d778fd1
Compare
|
bump LGTM, I was surprised to see github.com/onsi/ginkgo/ginkgo and github.com/jteeuwen/go-bindata/go-bindata leave Godeps.json |
|
Neither of those are actually included in the dependency tree - they are binaries we invoke. |
|
So godep save can't save them. |
|
[test] #9938 |
|
[merge] |
|
Evaluated for origin test up to d778fd1 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7518/) (Image: devenv-rhel7_4757) |
|
Evaluated for origin merge up to d778fd1 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7518/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleanup some Godeps incorrectness that crept in after a Godep save