cleanup oc version output #10602
Closed
cleanup oc version output #10602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanvallejo
force-pushed
the
jvallejo_update-oc-version-output
branch
from
141219b
to
869596f
Compare
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1368913 `openshift version` returns unformatted "GitVersion". This patch prints a cleaner output of the server version in `oc version` and `openshift version` commands. Before `$ openshift version` ``` openshift v1.3.0-alpha.0+1605423-dirty kubernetes v1.3.0+507d3a7 etcd 2.3.0+git ``` After `$ openshift version` ``` openshift v1.3.0-alpha.0 kubernetes v1.3.0+507d3a7 etcd 2.3.0+git` ``` `$ oc version` ``` oc v1.3.0-alpha.0 kubernetes v1.3.0+507d3a7 features: Basic-Auth Server https://10.13.137.149:8443 openshift v1.3.0-alpha.0 kubernetes v1.3.0+507d3a7 ```
juanvallejo
force-pushed
the
jvallejo_update-oc-version-output
branch
from
869596f
to
3968408
Compare
|
no, we want the git commit, and the indication that the build was from a dirty repo |
|
that is an indication that the build process is dirtying the working dir, which is concerning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1368913
openshift versionreturns unformatted "GitVersion".This patch prints a cleaner output of the server version in
oc versionand
openshift versioncommands.Before
$ openshift versionAfter
$ openshift version$ oc versioncc @fabianofranz