be tolerant of quota reconciler resetting to old values #10705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The intent here is to make the test more permissive to alleviate flakes that don't give us any new information about our system, but will the test be valid with the looser output requirement? |
Yes, anything over 9 indicates that the second project is recognized and the admission plugin is charging for it. |
|
SGTM, regex looks good |
|
LGTM approved for 1.3 [merge] |
|
device mapper flake #9490 [merge] |
|
flake: #10713 [merge] |
|
Evaluated for origin merge up to 04bc0fd |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8542/) (Image: devenv-rhel7_4952) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9929
This is the "off by one" (off by X since we started batching the updates) that is caused by a reconciliation check that doesn't get a complete list that includes secrets about to be created. The design here: kubernetes/kubernetes#20113 ought to resolve it.
@stevekuznetsov I hate bash
@mfojtik flake fix for 1.3. I don't think it will be a problem.