Fix clusterresourcequota annotations validation #10929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| os::cmd::try_until_text 'oc describe appliedclusterresourcequota/for-deads-by-annotation -n bar --as deads' "secrets.*1[0-9]" | ||
|
|
||
| os::cmd::expect_success 'oc delete project foo' | ||
| os::cmd::expect_success 'oc delete project bar' | ||
| os::cmd::expect_success 'oc delete project asmail' |
There was a problem hiding this comment.
We should be doing cleanup in a error-tolerant subshell at the start of the suite so that this suite is re-entrant if a run fails before cleanup occurs. See other test/cmd suites for an example.
|
[test] |
|
[test] flake on Service |
fabianofranz
force-pushed
the
release-1.3
branch
from
4b2a330
to
12e331b
Compare
|
Cherry-picked again after @stevekuznetsov comments in the master PR. |
fabianofranz
force-pushed
the
release-1.3
branch
from
12e331b
to
2d4e88f
Compare
|
Evaluated for origin test up to 2d4e88f |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9166/) |
|
@liggitt good to merge here? |
|
yes, [merge] |
|
continuous-integration/openshift-jenkins/merge Evaluating for testing |
|
Merge does not work on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #10912 to
release-1.3.