Fix the documentation to show how to set a custom message #11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparees
requested changes
Sep 27, 2016
| { "name": "RESPONSE", | ||
| "value": "Hello World!" | ||
| } | ||
| ], |
There was a problem hiding this comment.
would look nicer if you closed out the containers block.
I had added a feature to get a custom message from hello-openshift by using an environment variable. But when I documented it, I used oc set env (which worked for me since I was using a dc to test, but with a bare pod, it can not work). So, this changes the documentation to show how to set an env in the pod definition, and how to make use of it. Fixes openshift#11093
knobunc
force-pushed
the
issues/11093-fix-hello-openshift-message-docs
branch
from
bbc673b
to
9d9dc6d
Compare
|
lgtm [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9398/) (Image: devenv-rhel7_5093) |
|
Evaluated for origin merge up to 9d9dc6d |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 9d9dc6d |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9398/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had added a feature to get a custom message from hello-openshift by
using an environment variable. But when I documented it, I used oc
set env (which worked for me since I was using a dc to test, but with
a bare pod, it can not work). So, this changes the documentation to
show how to set an env in the pod definition, and how to make use of
it.
Fixes #11093