Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fake_buildconfigs methods #11163

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

guilhermebr
Copy link
Contributor

@guilhermebr guilhermebr commented Sep 29, 2016

This PR fixes the follow error when testing buildconfig Instantiate and InstantiateBinary methods:

error:

panic: interface conversion: runtime.Object is *api.BuildConfig, not *api.Build [recovered]
    panic: interface conversion: runtime.Object is *api.BuildConfig, not *api.Build

@bparees
Copy link
Contributor

bparees commented Sep 30, 2016

out of curiosity is there a test that's hitting this error, or were you trying to use it and encountered this? none of our tests are failing so i'm trying to understand how this came up.

@bparees
Copy link
Contributor

bparees commented Sep 30, 2016

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 762889c

@guilhermebr
Copy link
Contributor Author

@bparees I found this error in a new test I'm writing, I just opened separated because I don't have sure when I will finish this new test, and it have many other changes

@guilhermebr
Copy link
Contributor Author

guilhermebr commented Sep 30, 2016

@bparees if you want I can open the PR as WIP (without these change) for you see the test failing

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9541/)

@bparees
Copy link
Contributor

bparees commented Sep 30, 2016

@guilhermebr that's fine, i'll merge it, thanks!
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 762889c

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 30, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9548/) (Image: devenv-rhel7_5111)

@openshift-bot openshift-bot merged commit 8b46157 into openshift:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants