-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix fake_buildconfigs methods #11163
fix fake_buildconfigs methods #11163
Conversation
94e6baa
to
762889c
Compare
out of curiosity is there a test that's hitting this error, or were you trying to use it and encountered this? none of our tests are failing so i'm trying to understand how this came up. |
[test] |
Evaluated for origin test up to 762889c |
@bparees I found this error in a new test I'm writing, I just opened separated because I don't have sure when I will finish this new test, and it have many other changes |
@bparees if you want I can open the PR as WIP (without these change) for you see the test failing |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9541/) |
@guilhermebr that's fine, i'll merge it, thanks! |
Evaluated for origin merge up to 762889c |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9548/) (Image: devenv-rhel7_5111) |
This PR fixes the follow error when testing buildconfig
Instantiate
andInstantiateBinary
methods:error: