oc new-app: do not fail when file exists with same name as image #11918
Conversation
When "oc new-app foo/bar" was run in a directory with regular file named "foo" it failed with: error: unable to load template file "foo/bar": the path "foo/bar" cannot be accessed: stat foo/bar: not a directory Fixes bug 1393003.
|
it seems like we are handling the failure from the TemplateFileSearcher incorrectly.. a failure from the searcher should not fail the whole operation, as long as there are other Searchers we can try and one of them yields a successful result. At best i'd expect us to print these as warnings. |
|
that said, what you've done aligns w/ how the non-existent path case was being handled, so perhaps reworking all this logic is not appropriate to fix this. |
|
i'm going to call it lgtm for post 3.4. |
|
[merge] |
|
Evaluated for origin merge up to b94313c |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to b94313c |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11513/) (Base Commit: a4b7101) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11520/) (Base Commit: 9a21f9b) (Image: devenv-rhel7_5373) |
When "oc new-app foo/bar" was run in a directory with regular file named "foo" it failed with:
Fixes bug 1393003.
The fix feels a bit wrong, any hints how to fix this better appreciated.
@bparees or @fabianofranz PTAL?