Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 38196: fix mesos unit tests #12165

Merged
merged 1 commit into from Dec 7, 2016
Merged

UPSTREAM: 38196: fix mesos unit tests #12165

merged 1 commit into from Dec 7, 2016

Conversation

0xmichalis
Copy link
Contributor

Fixes #12157 which currently blocks the queue.
Upstream cherry-pick of kubernetes/kubernetes#38196.

cc: @smarterclayton @mfojtik @deads2k @liggitt

@ncdc I think the rebase will take a couple of days, or if you are so optimistic you can close this PR and pick the upstream change in yours. :)

@0xmichalis
Copy link
Contributor Author

[test]

@ncdc
Copy link
Contributor

ncdc commented Dec 7, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 7, 2016

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 1

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 74f64a7

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 74f64a7

@smarterclayton
Copy link
Contributor

Goog to direct merge as soon as I see tests pass

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12082/) (Base Commit: 4705adc)

@smarterclayton smarterclayton merged commit 5c6a1d4 into openshift:master Dec 7, 2016
@smarterclayton
Copy link
Contributor

Do we also need this on release-1.3 and 1.4?

@liggitt
Copy link
Contributor

liggitt commented Dec 7, 2016

yes >:-(

@0xmichalis 0xmichalis deleted the cherry-pick-upstream-38196 branch December 7, 2016 12:39
@0xmichalis
Copy link
Contributor Author

I will open PRs for the rest of the branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: ExternalID should not be able to resolve "mesos3.internal.company.com"
5 participants