Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better haproxy 503 page #12409

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Conversation

fabianofranz
Copy link
Member

Improves styling and information in the haproxy router error page.

503

@fabianofranz
Copy link
Member Author

@sg00dwin @jwforres

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@fabianofranz
Copy link
Member Author

@sspeiche please take a look at this proposal, if it looks good we'll get it merged to be in 3.5.

@sspeiche
Copy link
Contributor

sspeiche commented Jan 9, 2017

The thing I struggle with a bit is, thinking about an end user of OpenShift (a developer deploying apps): "What do I do as the owner of the application that is getting this message?".
Then I think if it as an application end user, what do I do with this information.

I believe you get this message if you have service port that doesn't match the pods.

Wouldn't you get a 404 if host doesn't exist? Guess not sure what host is in OpenShift terms and how a user would overcome this problem.

I'm a good example of someone who can deploy an application but when given this 503 message, I'd be a bit lost on what to do to fix it.

@knobunc
Copy link
Contributor

knobunc commented Jan 9, 2017 via email

@fabianofranz
Copy link
Member Author

Potentially both app developer and end-users of deployed apps can hit this page, so I think we must provide some troubleshooting info for developers but at the same time can't be too much technical. What about something like this (feel free to fine-tune the wording):

Possible reasons you're seeing this page:

  • The host doesn't exist. Make sure the hostname was typed correctly and that a route matching this hostname exists.
  • The host exists, but doesn't have a matching path. Check if the URL path was typed correctly and that the route was created including the desired path.
  • Route and path matches, but all pods are down. Make sure that the resources exposed by this route (pods, services, deployment configs, etc) have at least one pod running.

WDYT @sspeiche @jwforres @sg00dwin

@sspeiche
Copy link
Contributor

I think is good. Do we have any doc links we'd want to include in case a user says "I don't know what this is saying?" or is that getting crazy?

@jwforres
Copy link
Member

jwforres commented Jan 17, 2017 via email

@fabianofranz
Copy link
Member Author

@sspeiche unfortunately we can't add doc links here because this page is not customizable for the Origin/OCP/etc differences.

@fabianofranz
Copy link
Member Author

Updated, @sg00dwin please review?

Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabianofranz There's one extraneous rule to be removed, otherwise looks good to me.

}
a {
color: ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a {...} rule can be removed.

@fabianofranz
Copy link
Member Author

@sg00dwin fixed, tks!

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 17, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12966/) (Image: devenv-rhel7_5703)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to a7faf10

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to a7faf10

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/12966/) (Base Commit: eaa36ed)

@openshift-bot openshift-bot merged commit a05efad into openshift:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants