Switch to nip.io from xip.io for default cluster up wildcard DNS #13023
Conversation
|
+1 I like nip.io more than xip.io |
There was a problem hiding this comment.
The change LGTM, and as far as I can tell, it's working great.
Would like to get signoff from @smarterclayton and/or @bparees
test/extended/builds/gitauth.go
Outdated
| @@ -1,6 +1,6 @@ | |||
| package builds | |||
|
|
|||
| // these tests are diabled because the xip.io dns hook was proving way too unreliable; | |||
| // these tests are diabled because the nip.io dns hook was proving way too unreliable; | |||
There was a problem hiding this comment.
s/diabled/disabled/
also is it still unreliable?
There was a problem hiding this comment.
(the latter is probably more a question for @csrwng )
There was a problem hiding this comment.
We'd need to enable it and see. But I would create separate issue to look into that.
There was a problem hiding this comment.
@csrwng How about enabling it in this PR and running tests a few times to see if it solves the issue? That would give more confidence that this change actually switches to a more stable wildcard DNS service?
There was a problem hiding this comment.
Corrected old diabled typo btw
|
one nit, otherwise lgtm. |
|
Be sure to publicize this because people have scripted docs around it. |
|
Wouldn't be nice to have our own cool domain like minishift.io? xip.io/nip.io are just dns servers with custom scripts... and as a bonus we can have some stats about who is using it :D |
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
|
Any more thoughts on this? |
|
@jimmidyson I haven't seen any strong objections from the mailing lists |
|
[merge] |
|
Evaluated for origin merge up to d7d3b7c |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to d7d3b7c |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/709/) (Base Commit: 2cac04a) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/778/) (Base Commit: e164e80) (Image: devenv-rhel7_6026) |
Fixes #13020 if you're interested in doing that...