Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove external kubernetes proxy mode #13153

Closed
wants to merge 1 commit into from
Closed

Remove external kubernetes proxy mode #13153

wants to merge 1 commit into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Feb 28, 2017

Proxy mode was deprecated in 3.5 and will be removed for 3.6.

@deads2k
Copy link
Contributor

deads2k commented Feb 28, 2017 •
edited
Loading

lgtm merge

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 2477a49

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

sttts
sttts commented Mar 1, 2017
View reviewed changes
test/integration/service_account_test.go Outdated
@@ -107,6 +107,10 @@ func TestServiceAccountAuthorization(t *testing.T) {
t.Fatalf("error creating kubeconfig: %v", err)
}

// TODO(rebase): clarify whether we need anything of the following anymore if we drop proxy-only mode @liggitt
t.Logf("Skipping remaining external-kube based test")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt can you comment?

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/716/) (Base Commit: 2cac04a)

@deads2k
Copy link
Contributor

deads2k commented Mar 2, 2017

@sttts some sort of verify error.

@sttts sttts force-pushed the sttts-ext-kube-proxy-mode branch from 2477a49 to 3bbcdb2 Compare March 3, 2017 08:00
@sttts
Copy link
Contributor Author

sttts commented Mar 3, 2017

[test]

@deads2k
Copy link
Contributor

deads2k commented Mar 3, 2017

re[test]

@sttts sttts force-pushed the sttts-ext-kube-proxy-mode branch from 3bbcdb2 to c9c82ab Compare March 7, 2017 10:14
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to c9c82ab

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/894/) (Base Commit: 11034b2)

@sttts
Copy link
Contributor Author

sttts commented Mar 7, 2017

re[test]

@openshift-bot
Copy link
Contributor

The Origin test job could not be run again for this pull request.

  • If the proposed changes in this pull request caused the job to fail, update this pull request with new code to fix the issue(s).
  • If flaky tests caused the job to fail, leave a comment with links to the GitHub issue(s) in the openshift/origin repository with the kind/test-flake label that are tracking the flakes. If no issue already exists for the flake you encountered, create one.
  • If something else like CI system downtime or maintenance caused the job to fail, contact a member of the Team Project Committers group to trigger the job again.

@deads2k
Copy link
Contributor

deads2k commented Mar 7, 2017

@sttts looks like a real failure. At least one test timeout which is unusual in origin. I'm trying to figure out where we can write up bugs against our CI.

@openshift-bot
Copy link
Contributor

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2017
@sttts
Copy link
Contributor Author

sttts commented Mar 20, 2017

This was part of the apigroups PR. Closing.

@sttts sttts closed this Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deads2k deads2k

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sttts @deads2k @openshift-bot