Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept the $JUNIT_REPORT flag in networking tests #13320

Merged

Conversation

stevekuznetsov
Copy link
Contributor

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

[test]

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 5804d85

@stevekuznetsov
Copy link
Contributor Author

Hmm... we don't seem to grab the /tmp/openshift/test-extended directory. I've added some debugging .. let's see more tests

@@ -318,6 +318,13 @@ else

os::util::environment::setup_tmpdir_vars "test-extended/networking"

# Allow setting $JUNIT_REPORT to toggle output behavior
if [[ -n "${JUNIT_REPORT:-}" ]]; then
export JUNIT_REPORT_OUTPUT="${LOG_DIR}/raw_test_output.log"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the raw output should vary by plugin, as the regular output already does or the output of only one of the plugins will be saved:

https://github.com/openshift/origin/blob/master/test/extended/networking.sh#L167

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the logging from the os::cmd tests, if there are any, not for the jUnit from Ginkgo.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/83/) (Base Commit: d3a3181)

@stevekuznetsov
Copy link
Contributor Author

@marun can you affirm that the jUnit results we got from https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_networking_minimal/103/testReport/ are correct?

@stevekuznetsov
Copy link
Contributor Author

[merge] we'll at least get some, if not all of them this way

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 5804d85

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 10, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/29/) (Base Commit: d922c93) (Image: devenv-rhel7_6063)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants