Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error event type panic in StatefulSet e2e tests #13939

Merged
merged 1 commit into from Apr 28, 2017
Merged

Fix error event type panic in StatefulSet e2e tests #13939

merged 1 commit into from Apr 28, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Apr 28, 2017 •
edited by deads2k

Should fix #13905 (comment).

@sttts
Copy link
Contributor Author

sttts commented Apr 28, 2017

[test]

@deads2k
Copy link
Contributor

deads2k commented Apr 28, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 28, 2017 •
edited

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 11

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 514bc6c

@deads2k
Copy link
Contributor

deads2k commented Apr 28, 2017

@sttts did not fix the problem: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1023/

@deads2k
Copy link
Contributor

deads2k commented Apr 28, 2017

flaked on #13943 and #13942

@deads2k
Copy link
Contributor

deads2k commented Apr 28, 2017

re[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 514bc6c

@sttts sttts mentioned this pull request Apr 28, 2017
Closed
@sttts
Copy link
Contributor Author

sttts commented Apr 28, 2017

@deads2k the panic is gone. But a broken watch showed up.

@deads2k
Copy link
Contributor

deads2k commented Apr 28, 2017

@deads2k the panic is gone. But a broken watch showed up.

oh, awesome. People will think they're the same. Add details to the issue?

If the test is using watch.Until, it's probably not handling watch window expiration with a relist operation.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1027/) (Base Commit: 1596f74)

@deads2k
Copy link
Contributor

deads2k commented Apr 28, 2017

flake fix. merging

@deads2k deads2k merged commit 1d145d7 into openshift:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sttts @deads2k @openshift-bot @smarterclayton @dshulyak