Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY out script cleanup code #14116

Merged
merged 3 commits into from May 13, 2017
Merged

DRY out script cleanup code #14116

merged 3 commits into from May 13, 2017

Commits on May 11, 2017

  1. Disable swap in Go build 

    We have migrated to Go 1.7+ and as such we no longer need to be enabling
swap space for our builds.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
    @stevekuznetsov
    stevekuznetsov committed May 11, 2017
    Configuration menu
    Copy the full SHA
    82385ca View commit details
    Browse the repository at this point in the history

  2. Automatically determine which type of jUnit report to generate 

    We can tell from the raw test output file which type of test was used to
create the output, so we do not need users to have to specify which type
of parsing and report they would like.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
    @stevekuznetsov
    stevekuznetsov committed May 11, 2017
    Configuration menu
    Copy the full SHA
    16ab6dd View commit details
    Browse the repository at this point in the history

  3. DRY out script cleanup code 

    Almost every single cleanup function trapped on exit for our scripts was
taking the same actions in the same order. We can break that out into a
standalone function under `hack/lib` that contains a superset of all the
cleanup steps used, provided that we make sure each individual clean up
step can gracefully handle the case where it is not needed or does not
have any work to do.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
    @stevekuznetsov
    stevekuznetsov committed May 11, 2017
    Configuration menu
    Copy the full SHA
    8c7f1a7 View commit details
    Browse the repository at this point in the history