DRY out script cleanup code #14116
Merged
DRY out script cleanup code #14116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-bot
added
the
needs-rebase
stevekuznetsov
force-pushed
the
skuznets/cleanup_all
branch
5 times, most recently
from
8c1675d
to
f8940f0
Compare
stevekuznetsov
removed
the
needs-rebase
|
Lgtm merge at will
|
stevekuznetsov
force-pushed
the
skuznets/cleanup_all
branch
7 times, most recently
from
b8c8683
to
ed72c67
Compare
We have migrated to Go 1.7+ and as such we no longer need to be enabling swap space for our builds. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
We can tell from the raw test output file which type of test was used to create the output, so we do not need users to have to specify which type of parsing and report they would like. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Almost every single cleanup function trapped on exit for our scripts was taking the same actions in the same order. We can break that out into a standalone function under `hack/lib` that contains a superset of all the cleanup steps used, provided that we make sure each individual clean up step can gracefully handle the case where it is not needed or does not have any work to do. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/cleanup_all
branch
from
ed72c67
to
8c7f1a7
Compare
|
[test][merge] |
|
Evaluated for origin test up to 8c7f1a7 |
|
Evaluated for origin merge up to 8c7f1a7 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1374/) (Base Commit: 012de50) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/625/) (Base Commit: a2e505b) (Image: devenv-rhel7_6228) |
This was referenced May 15, 2017
|
This kills my docker containers when i run update-generated-swagger-spec has nothing to do with docker containers or etcd data directory. |
|
Since we start a server for Swagger anyway I'm pretty sure container cleanup was pre-existing. We haven't changed the logic for which containers we target for cleanup. Which ones are you seeing killed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable swap in Go build
We have migrated to Go 1.7+ and as such we no longer need to be enabling
swap space for our builds.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
Automatically determine which type of jUnit report to generate
We can tell from the raw test output file which type of test was used to
create the output, so we do not need users to have to specify which type
of parsing and report they would like.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
DRY out script cleanup code
Almost every single cleanup function trapped on exit for our scripts was
taking the same actions in the same order. We can break that out into a
standalone function under
hack/libthat contains a superset of all thecleanup steps used, provided that we make sure each individual clean up
step can gracefully handle the case where it is not needed or does not
have any work to do.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/cc @smarterclayton PTAL
[test]