Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-images: Use https for yum repo #14451

Merged

Conversation

chlunde
Copy link
Contributor

@chlunde chlunde commented Jun 2, 2017

buildlogs.centos.org is now on https. yum failed to follow the
http to https redirect, so change the URL to https to avoid the redirect:

./hack/build-base-images.sh
--> FROM openshift/origin-source
--> RUN INSTALL_PKGS="bsdtar ceph-common device-mapper device-mapper-persistent-data e2fsprogs epel-release ethtool findutils git hostname iptables lsof nmap-ncat socat sysvinit-tools tar tree util-linux wget which xfsprogs" &&     yum --disablerepo=origin-local-release install -y ${INSTALL_PKGS} &&     rpm -V ${INSTALL_PKGS} &&     yum clean all &&     mkdir -p /var/lib/origin
Loaded plugins: fastestmirror, ovl
http://buildlogs.centos.org/centos/7/paas/x86_64/openshift-origin36/repodata/repomd.xml: [Errno 14] HTTPS Error 302 - Found
Trying other mirror.


 One of the configured repositories failed (CentOS PaaS SIG Origin 3.6 Repository),
...
            yum-config-manager --save --setopt=centos-paas-sig-openshift-origin36.skip_if_unavailable=true

failure: repodata/repomd.xml from centos-paas-sig-openshift-origin36: [Errno 256] No more mirrors to try.
http://buildlogs.centos.org/centos/7/paas/x86_64/openshift-origin36/repodata/repomd.xml: [Errno 14] HTTPS Error 302 - Found

buildlogs.centos.org is now on https.  yum failed to follow the
http to https redirect, so change the URL to https to avoid the redirect:

    http://buildlogs.centos.org/centos/7/paas/x86_64/openshift-origin36/repodata/repomd.xml:
    [Errno 14] HTTPS Error 302 - Found
@arrfab
Copy link

arrfab commented Jun 2, 2017

Just to comment on this : we always had redirect in place for more than one year (just for the CDN backend) and we enforced https already on Jan 30 2017 (just had a look at puppet/git)

@chlunde
Copy link
Contributor Author

chlunde commented Jun 2, 2017

The problem with handling redirects in yum is only an issue when there's a TLS content inspection proxy in place.

Still, the site is now https so there's no point in having it use http in the config file.

@chlunde chlunde changed the title base-base-images: Use https for yum repo base-images: Use https for yum repo Jun 2, 2017
@stevekuznetsov
Copy link
Contributor

[test]

@stevekuznetsov
Copy link
Contributor

@chlunde thanks for the contribution! Let's see this pass tests and merge. Would you mind doing PRs to the release-1.4 and release-1.5 branches with the same fix?

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 1684e8f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2017/) (Base Commit: c824f5c)

@stevekuznetsov
Copy link
Contributor

[merge][severity: bug]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 1684e8f

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 9, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/933/) (Base Commit: 1257438) (Extended Tests: bug) (Image: devenv-rhel7_6333)

@openshift-bot openshift-bot merged commit 2458531 into openshift:master Jun 9, 2017
@chlunde chlunde deleted the use-https-centos-paas-yum-repo branch June 9, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants