New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document dependencies for build-base-images.sh #14613
Conversation
Thanks for updating the doc. However, to be a little more correct, could you update the message -- today, all of our container image builds require |
HACKING.md
Outdated
@@ -18,6 +18,8 @@ To build the base and release images, run: | |||
|
|||
$ hack/build-base-images.sh | |||
|
|||
hack/build-base-images.sh Depends on [imagebuilder](https://github.com/openshift/imagebuilder). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Depends/depends/
Those are fair enough points, reviewed. |
[merge] |
@juanluisvaladas Kudos to you for helping to keep doc up-to-date. |
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 17 |
Evaluated for origin merge up to 7a59a25 |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 7a59a25 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2213/) (Base Commit: c7a38d7) |
Build-base-images depends on imagebuilder which won't be installed or pulled by default.