Make the master endpoint lease ttl configurable #15214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pweil-
reviewed
Jul 14, 2017
| // MasterEndpointReconcileTTL sets the time to live in seconds of an endpoint record recorded by each master. The endpoints are checked | ||
| // at an interval that is 2/3 of this value and this value defaults to 15s if unset. In very large clusters, this value may be increased to | ||
| // reduce the possibility that the master endpoint record expires (due to other load on the etcd server) and causes masters to drop in and | ||
| // out of the kubernetes service record. It is not recommended to set this value below 15s. |
There was a problem hiding this comment.
I suppose this could be a warning in the ValidateMasterConfig if it may cause problems
There was a problem hiding this comment.
I don't know if it's terrible. I expect no one to set unless we tell them
Very large clusters can fail to update TTL in a reasonable time.
smarterclayton
force-pushed
the
configurable_ttl
branch
from
b9cfbb3
to
72514e8
Compare
|
Evaluated for origin test up to 72514e8 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3180/) (Base Commit: 987a609) (PR Branch Commit: 72514e8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very large clusters can fail to update TTL in a reasonable time.
Fixes #15212
[test] @liggitt @pweil-