Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO_NOT_MERGE] bump broker waitforready timeout #15439

Closed
wants to merge 1 commit into from
Closed

[DO_NOT_MERGE] bump broker waitforready timeout #15439

wants to merge 1 commit into from

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jul 24, 2017 •
edited
Loading

fixes #15405

@openshift-merge-robot openshift-merge-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2017
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2017
@smarterclayton
Copy link
Contributor

/approve no-issue

@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2017

stop. this didn't fix anything.

@smarterclayton
Copy link
Contributor

Definitely not detecting the issue

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, smarterclayton

Associated issue requirement bypassed by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2017
@smarterclayton smarterclayton removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 26, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2017
@bparees bparees changed the title bump broker waitforready timeout [DO_NOT_MERGE] bump broker waitforready timeout Jul 26, 2017
@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2017

hm. it re-added the approved label? was it supposed to do that?

@openshift-merge-robot openshift-merge-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2017
@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2017

/test extended_templates

@openshift openshift deleted a comment from openshift-bot Jul 26, 2017
@openshift openshift deleted a comment from openshift-bot Jul 26, 2017
@openshift-merge-robot openshift-merge-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2017
@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2017

/test extended_templates

@bparees bparees mentioned this pull request Jul 26, 2017
Closed
@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2017

/retest

2 similar comments
@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2017

/retest

@bparees
Copy link
Contributor Author

bparees commented Jul 26, 2017

/retest

@openshift-ci-robot
Copy link

@bparees: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_templates 0191312 link /test extended_templates
ci/openshift-jenkins/extended_conformance_gce 0191312 link /test extended_conformance_gce

Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, smarterclayton

Associated issue requirement bypassed by: smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jim-minter
Copy link
Contributor

IMO this PR should definitely not be merged.

@bparees
Copy link
Contributor Author

bparees commented Jul 31, 2017

@jim-minter once it evolved beyond seeing if bumping the timeout to 30s would fix the issue, there were no plans to merge it.

@bparees bparees closed this Jul 31, 2017
@bparees bparees deleted the broker_timeout branch July 31, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template broker extended tests fail to get catalog reference
6 participants
@bparees @smarterclayton @openshift-merge-robot @openshift-ci-robot @jim-minter @mfojtik