start a command for running the template service broker #15655
Conversation
openshift-merge-robot
added
the
size/L
openshift-merge-robot
added
the
approved
|
/cc @smarterclayton |
| if err != nil { | ||
| return err | ||
| } | ||
| return server.GenericAPIServer.PrepareRun().Run(stopCh) |
There was a problem hiding this comment.
nit, but maybe name server here something slightly different so it doesn't conflict with the imported pkg "github.com/openshift/origin/pkg/openservicebroker/server"
There was a problem hiding this comment.
nit, but maybe name server here something slightly different so it doesn't conflict with the imported pkg "github.com/openshift/origin/pkg/openservicebroker/server"
As I make it more apiserver like, I think we'll change in the other direction.
|
/test extended_conformance_install_update |
|
/retest |
1 similar comment
|
/retest |
|
We seem to be having some weird yum and docker issues across multiple pulls. |
|
/test end_to_end |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
bparees
removed
approved
openshift-merge-robot
added
the
approved
bparees
removed
the
approved
openshift-merge-robot
added
the
approved
bparees
removed
the
approved
openshift-merge-robot
added
the
approved
|
@bparees I think you're looking for |
|
|
||
| func (o TemplateServiceBrokerServerOptions) Config() (*server.TemplateServiceBrokerConfig, error) { | ||
| // TODO have a "real" external address | ||
| if err := o.RecommendedOptions.SecureServing.MaybeDefaultWithSelfSignedCerts("localhost", nil, []net.IP{net.ParseIP("127.0.0.1")}); err != nil { |
There was a problem hiding this comment.
at what point is this going to serve with a cert signed by the cluster CA? Isn't that going to be necessary for the SC to cleanly talk to it?
There was a problem hiding this comment.
at what point is this going to serve with a cert signed by the cluster CA? Isn't that going to be necessary for the SC to cleanly talk to it?
Never. Serving will happen with a cert created and signed by the service serving cert signing. This sets up a default if you don't pass one in, making the "no args run" work.
|
/test verify |
|
Automatic merge from submit-queue |
This stubs in a command with the full set of "normal" flags. I didn't see admission plugins, so those aren't wired up.
You'll need to finish the client config wiring for clients and informers, but this shows you'll need to add those.
@liggitt @bparees @jim-minter