Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snip TSB links #16217

Merged
merged 1 commit into from
Sep 11, 2017
Merged

snip TSB links #16217

merged 1 commit into from
Sep 11, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 7, 2017

This removes a couple unnecessary dependencies from the TSB in preparation for a later switch to https://github.com/openshift/client-go

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2017
@csrwng
Copy link
Contributor

csrwng commented Sep 7, 2017

/unassign
/assign @jim-minter

@deads2k
Copy link
Contributor Author

deads2k commented Sep 7, 2017

/retest

deads2k
deads2k commented Sep 7, 2017
View reviewed changes
pkg/serviceaccounts/client.go
kclientsetexternal "k8s.io/kubernetes/pkg/client/clientset_generated/clientset"
kclientsetinternal "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset"

"github.com/openshift/origin/pkg/client"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevekuznetsov this transitive wasn't picked up before. Weird. Known?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we merge upstream fix and rebase to grab it? There was an issue with prefixing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we merge upstream fix and rebase to grab it? There was an issue with prefixing.

Ok, known. Thanks.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 8, 2017

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Sep 8, 2017

/assign jim-minter

@jim-minter
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jim-minter

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 2347b52 into openshift:master Sep 11, 2017
@deads2k deads2k deleted the tsb-25-snip branch January 24, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

Assignees

@jim-minter jim-minter

@jwforres jwforres

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deads2k @csrwng @jim-minter @openshift-merge-robot @stevekuznetsov @jwforres @openshift-ci-robot