Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --output & --dry-run options to oc-adm-policy sub-commands #16218

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Sep 7, 2017

Fixes #14808

Adds --output flags with support for json and yaml output to every oc adm policy sub-command, as well as --dry-run flag support to several sub-commands.

Still have a few sub-commands left to update, but opening PR to begin gathering any feedback.

cc @openshift/cli-review

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2017
@stevekuznetsov
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2017
@stevekuznetsov
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2017
@stevekuznetsov
Copy link
Contributor

/close

@stevekuznetsov
Copy link
Contributor

/open

@stevekuznetsov
Copy link
Contributor

@Kargakis is /open supposed to work?

@stevekuznetsov stevekuznetsov reopened this Sep 7, 2017
@stevekuznetsov stevekuznetsov changed the title [WIP] add --output & --dry-run options to oc-adm-policy sub-commands [WIP] add --output & --dry-run options to oc-adm-policy sub-commands Sep 7, 2017
@openshift-ci-robot
Copy link

@juanvallejo: Your pull request title starts with "[WIP]", so the do-not-merge/work-in-progress label will be added.

This label will ensure that your pull request will not be merged. Remove the prefix from your pull request title to trigger the removal of the label and allow for your pull request to be merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2017
@0xmichalis
Copy link
Contributor

@stevekuznetsov /reopen it is

@juanvallejo juanvallejo force-pushed the jvallejo/add-output-dry-run-oc-adm-policy branch 2 times, most recently from 68c82cd to 0f87e27 Compare September 12, 2017 22:15
@juanvallejo juanvallejo changed the title [WIP] add --output & --dry-run options to oc-adm-policy sub-commands add --output & --dry-run options to oc-adm-policy sub-commands Sep 13, 2017
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2017
@juanvallejo juanvallejo force-pushed the jvallejo/add-output-dry-run-oc-adm-policy branch 3 times, most recently from 677abe6 to 199444a Compare September 13, 2017 20:15
@stevekuznetsov
Copy link
Contributor

Too far away from this code to review

/unassign

@juanvallejo
Copy link
Contributor Author

/test end_to_end

@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install_update

1 similar comment
@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install_update

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2017
@juanvallejo juanvallejo force-pushed the jvallejo/add-output-dry-run-oc-adm-policy branch from 199444a to 609c558 Compare September 22, 2017 15:16
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2017
@juanvallejo
Copy link
Contributor Author

cc @fabianofranz

@fabianofranz
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16439, 16218, 16387, 16509)

@openshift-merge-robot openshift-merge-robot merged commit 846c827 into openshift:master Sep 23, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2017

@juanvallejo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 609c558 link /test cmd
ci/openshift-jenkins/extended_conformance_gce 609c558 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juanvallejo juanvallejo deleted the jvallejo/add-output-dry-run-oc-adm-policy branch September 25, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants