Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm: Remove 1.13 from excluder #17026

Merged
merged 1 commit into from
Oct 25, 2017
Merged

rpm: Remove 1.13 from excluder #17026

merged 1 commit into from
Oct 25, 2017

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented Oct 24, 2017

The oldest docker version available in Fedora 26 is 1.13.

Fixes: openshift/openshift-ansible#5833

@ashcrow
rpm: Remove 1.13 from excluder
d74d913 
The oldest docker version available in Fedora 26 is 1.13.

Fixes: openshift/openshift-ansible#5833

Signed-off-by: Steve Milner <smilner@redhat.com>
@ashcrow ashcrow added the kind/bug Categorizes issue or PR as related to a bug. label Oct 24, 2017
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2017
@ashcrow ashcrow mentioned this pull request Oct 24, 2017
Closed
@sdodson
Copy link
Member

sdodson commented Oct 25, 2017

/approve
/Lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2017
@sdodson
Copy link
Member

sdodson commented Oct 25, 2017

/kind bug

@deads2k
Copy link
Contributor

deads2k commented Oct 25, 2017

/approve

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, deads2k, sdodson

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17020, 17026, 17000, 17010).

@openshift-merge-robot openshift-merge-robot merged commit 6cf2dbd into openshift:master Oct 25, 2017
@0xmichalis
Copy link
Contributor

/cherrypick release-3.6

@openshift-ci-robot
Copy link

@Kargakis: New pull request created: #17046

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 26, 2017
Closed
@sdodson
Copy link
Member

sdodson commented Oct 26, 2017

/cherrypick release-3.6

Are we saying that 3.6 supports docker-1.13 in both origin and ocp?

@0xmichalis
Copy link
Contributor

No, I was just testing the command, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson Awaiting requested review from sdodson

@tdawson tdawson Awaiting requested review from tdawson

Assignees

@sdodson sdodson

@bparees bparees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ashcrow @sdodson @deads2k @openshift-merge-robot @0xmichalis @openshift-ci-robot @bparees