prevent err message when removing env vars #17119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/lgtm |
openshift-merge-robot
added
the
approved
This patch updates `oc set env ...` to avoid returning an error message when removing environment variables via the `--env` flag.
juanvallejo
force-pushed
the
jvallejo/prevent-err-msg-if-deleting-env-var
branch
from
d0f9477
to
a9bf084
Compare
openshift-merge-robot
removed
the
lgtm
|
@fabianofranz added a small test, wondering if you can re-tag? thx! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianofranz, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 17014, 16822, 17081, 17119, 17107). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17041
This patch updates
oc set env ...to avoid returning an error messagewhen removing environment variables via the
--envflag.cc @openshift/cli-review