Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/newapp: Wait longer for imagestream import to finish #17506

Merged
merged 1 commit into from
Dec 14, 2017
Merged

cmd/newapp: Wait longer for imagestream import to finish #17506

merged 1 commit into from
Dec 14, 2017

Conversation

miminar
Copy link

@miminar miminar commented Nov 29, 2017

Resolves #15015

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2017
@miminar
Copy link
Author

miminar commented Nov 29, 2017

/test

@0xmichalis
Copy link
Contributor

/approve

@runcom
Copy link
Member

runcom commented Nov 29, 2017

/test crio

1 similar comment
@runcom
Copy link
Member

runcom commented Nov 29, 2017

/test crio

@danwinship danwinship removed their request for review November 29, 2017 13:11
@miminar miminar force-pushed the image-stream-import-cmd-testflake-fix-15015 branch from a875c23 to 20d950c Compare November 30, 2017 11:33
@miminar
Copy link
Author

miminar commented Nov 30, 2017

Really increased the timeout to 2 minutes instead of 120 milliseconds.

@dmage
Copy link
Contributor

dmage commented Dec 8, 2017

just want to check CI stuff
/test extended_image_registry
/test extended_image_ecosystem

@miminar
Copy link
Author

miminar commented Dec 11, 2017

@Kargakis ping

@0xmichalis
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2017
@0xmichalis
Copy link
Contributor

/assign bparees

bparees
bparees requested changes Dec 11, 2017
View reviewed changes
test/cmd/newapp.sh Outdated
os::cmd::try_until_success 'oc get imagestreamtags mysql:5.5'
os::cmd::try_until_success 'oc get imagestreamtags mysql:5.6'
os::cmd::try_until_success 'oc get imagestreamtags mysql:5.7'
os::cmd::try_until_success 'oc get imagestreamtags mysql:latest' $((2*60*1000))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os::util::environment::setup_time_vars

and then

2*TIME_MIN

cmd/newapp: Wait longer for imagestream import to finish
d853aff 
Resolves openshift#15015

Signed-off-by: Michal Minář <miminar@redhat.com>
@miminar miminar force-pushed the image-stream-import-cmd-testflake-fix-15015 branch from 20d950c to d853aff Compare December 11, 2017 16:49
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2017
@bparees
Copy link
Contributor

bparees commented Dec 11, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, kargakis, miminar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2017
@0xmichalis 0xmichalis mentioned this pull request Dec 11, 2017
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2017 •
edited
Loading

@miminar: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_crio a875c23 link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 51d3ec1 into openshift:master Dec 14, 2017
@miminar miminar deleted the image-stream-import-cmd-testflake-fix-15015 branch February 22, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees bparees requested changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@0xmichalis 0xmichalis

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@miminar @0xmichalis @runcom @dmage @bparees @openshift-ci-robot @openshift-bot @openshift-merge-robot