Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore deep copy generation #17662

Merged
merged 1 commit into from Dec 8, 2017
Merged

restore deep copy generation #17662

merged 1 commit into from Dec 8, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 7, 2017

We still need deep copy for types we haven't move (those should probably be moved) and internal types (these will stay). Found this while messing with the rebase.

/assign mfojtik

@bparees @enj fyi

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2017
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 7, 2017

@Kargakis can you point me at directions for the cherry-pick bot?

soltysh
soltysh approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mfojtik
Copy link
Member

mfojtik commented Dec 7, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@0xmichalis
Copy link
Contributor

@deads2k /cherrypick release-3.x is what you want?

@enj
Copy link
Contributor

enj commented Dec 7, 2017

@simo5 this is probably what broke your deep copies.

@simo5
Copy link
Contributor

simo5 commented Dec 7, 2017

/test integration
/test end_to_end

@deads2k
Copy link
Contributor Author

deads2k commented Dec 7, 2017

/cherrypick release-3.8

@openshift-cherrypick-robot
Copy link

@deads2k: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Dec 7, 2017

wow green tests. so rare these days

@0xmichalis
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 7de98f2 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17662, 17664).

@openshift-merge-robot openshift-merge-robot merged commit ead4a2d into openshift:master Dec 8, 2017
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 8, 2017
Merged
@openshift-cherrypick-robot
Copy link

@deads2k: new pull request created: #17680

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simo5 simo5 mentioned this pull request Dec 8, 2017
Merged
openshift-merge-robot added a commit that referenced this pull request Dec 12, 2017
@openshift-merge-robot
Merge pull request #17680 from openshift-cherrypick-robot/cherry-pick…
4f0db51 
…-17662-to-release-3.8

Automatic merge from submit-queue.

Automated cherry-pick of #17662 on release-3.8

This is an automated cherry-pick of #17662

/assign deads2k
@deads2k deads2k deleted the api-13-deepcopy branch January 24, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@deads2k @mfojtik @openshift-ci-robot @0xmichalis @enj @simo5 @openshift-cherrypick-robot @openshift-merge-robot @soltysh