New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address bld forcepull ext test etc update conflict flake #17840
Conversation
this doesn't resolve 100% of the problem since conflicts can still occur on the add-cluster-role-to-user call too. The add needs a retry on conflict loop. Or you can wait for @enj to fix #17596 (which is a dupe of the issue you referenced) properly (add generic retrying to the role management api) So this is a fine simplification but not the full solution. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 17744, 17840, 17874). |
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #17836
@openshift/sig-developer-experience ptal