Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address bld forcepull ext test etc update conflict flake #17840

Merged
merged 1 commit into from Dec 20, 2017

Conversation

gabemontero
Copy link
Contributor

Fixes #17836

@openshift/sig-developer-experience ptal

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2017
@bparees
Copy link
Contributor

bparees commented Dec 15, 2017

this doesn't resolve 100% of the problem since conflicts can still occur on the add-cluster-role-to-user call too.

The add needs a retry on conflict loop. Or you can wait for @enj to fix #17596 (which is a dupe of the issue you referenced) properly (add generic retrying to the role management api)

So this is a fine simplification but not the full solution.

/lgtm
/hold
remove the hold when tests pass

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 15, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2017
@gabemontero gabemontero removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2017
@gabemontero
Copy link
Contributor Author

thanks for the info @bparees

this test passed in extended builds so removing hold tag

will wait a bit on @enj 's progress with #17596 before adding any retry in the forcepull test

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17744, 17840, 17874).

@openshift-merge-robot openshift-merge-robot merged commit d62d6aa into openshift:master Dec 20, 2017
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 20, 2017

@gabemontero: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 8c6bf4e link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero gabemontero deleted the forcepull branch December 24, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants